Fix marlin model loading compat with autogptq #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have reviewed this PR. @merrymercy @hnyls2002 Ready for review/merge. AutoGPTQ main actually has broken Marlin direct quantize support. Use my pending PR AutoGPTQ/AutoGPTQ#586 to quant Marlin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issue #289
Autogptq uses is_marlin_format for Marlin. So depending on how/tool used to quantize, it can be quant_method=="marlin" or quant_method=="gptq" and is_marlin_format==True. Technically, Marlin is a format, not new quant method so autogptq way is more correct. But regardless, this PR will allow both methods to work.