Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env (docker) compat due to __file__ usage #288

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Qubitium
Copy link
Contributor

Fix Issue #274

Replace __file__ with importlib.resources.

@lucasavila00 Please confirm this fixed your issue.

@lucasavila00
Copy link

lucasavila00 commented Mar 13, 2024

This fixed the issue I had.

Thanks 🙏

@Qubitium Qubitium changed the title [WIP] Fix env (docker) compat due to __file__ usage Fix env (docker) compat due to __file__ usage Mar 13, 2024
@Qubitium
Copy link
Contributor Author

@merrymercy @hnyls2002 Bug fix confirmed by @lucasavila00. PR ready for review/merge.

@hnyls2002 hnyls2002 merged commit 92e2d74 into sgl-project:main Mar 13, 2024
@Qubitium Qubitium deleted the use-importlib branch March 28, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants