replace skip_embed with input_embeds #222
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace the arg
skip_embed: bool
withinput_embeds: torch.Tensor
in the forward functions of all the language models.This fixes the bug raised by LogitsProcessor when using llava in Extend mode and return log_prob, such as using
gen(choices=[...])
with llava, where LogitsProcessor need to receive input_ids and uses it to get the token logprob. However, the input_ids given to LogitsProcessor by llava is actually the input embedding, which will cause a Tensor dimension mismatch error.