Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import outlines #168

Merged
merged 1 commit into from
Feb 9, 2024
Merged

import outlines #168

merged 1 commit into from
Feb 9, 2024

Conversation

hnyls2002
Copy link
Collaborator

@hnyls2002 hnyls2002 commented Feb 8, 2024 •
edited
Loading

No description provided.

@hnyls2002 hnyls2002 merged commit 37b4229 into main Feb 9, 2024
@hnyls2002 hnyls2002 deleted the outlines-integration branch February 9, 2024 02:13
This was referenced Feb 9, 2024
Closed
Closed
isidentical added a commit to isidentical/sglang that referenced this pull request Feb 16, 2024
@isidentical
Revert "import outlines (sgl-project#168)"
79a4bf7 
This reverts commit 37b4229.
@isidentical
Copy link

Looks like this PR broke compatibility with pydantic<2 which still has many users (Because of transitive dependencies) :/ I'll try to maintain a fork without it, but I'd love if there was at least some sort of a grace period for it where both revisions maybe maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hnyls2002 @isidentical