Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not writing empty xmodmap files anymore #531

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Not writing empty xmodmap files anymore #531

merged 2 commits into from
Nov 5, 2022

Conversation

sezanzeb
Copy link
Owner

@sezanzeb sezanzeb commented Nov 5, 2022 •
edited
Loading

Noticed that xmodmap.json related logs were written even though xmodmap was not installed:

Optional `xmodmap` command not found. This is not critical.
Writing ".../xmodmap.json"

Using keycodes from ".../xmodmap.json"

This log was confusing

@sezanzeb sezanzeb merged commit 27e911b into beta Nov 5, 2022
@sezanzeb sezanzeb mentioned this pull request Nov 5, 2022
Open
@sezanzeb sezanzeb deleted the no-empty-xmodmap-files branch November 13, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sezanzeb