Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not install under the old name any more #373

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

mjg
Copy link
Contributor

@mjg mjg commented Apr 19, 2022

Just in case "some point in time" is now, here's a PR to avoid the old name :)

@sezanzeb sezanzeb added this to todo in 2.0 Nov 1, 2022
@sezanzeb sezanzeb changed the base branch from main to beta November 13, 2022 12:42
@sezanzeb
Copy link
Owner

sezanzeb commented Mar 1, 2023

Hi, I'd like to remove the old binaries for the 2.0.0 release.

There are some conflicts here, probably because of some minor change in the executables like the copyright year or something on the beta branch.

If you prepare the merge request to be based on the current beta I'll merge it soon.

@mjg
Copy link
Contributor Author

mjg commented Mar 1, 2023

Hi, I'd like to remove the old binaries for the 2.0.0 release.

There are some conflicts here, probably because of some minor change in the executables like the copyright year or something on the beta branch.

If you prepare the merge request to be based on the current beta I'll merge it soon.

You merged the beta branch into this PR if I read this right. Should I rebase my branch on beta and force push it here (removing that merge)? Just making sure I'll match your flow.

@sezanzeb
Copy link
Owner

sezanzeb commented Mar 1, 2023

I'll squash the commits from this PR anyway, do whatever works to make your desired change

@sezanzeb sezanzeb changed the base branch from beta to main March 2, 2023 17:14
@sezanzeb sezanzeb merged commit 394c05d into sezanzeb:main Mar 2, 2023
@sezanzeb sezanzeb moved this from todo to done in 2.0 Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.0
done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants