partial solution; wrapper.name is sometimes undefined #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#540
This is a partial solution but it resolves the issue of a div being created every undo/redo which could lead to hundreds or even thousands of unused divs taking up memory after a session has last for sometime.
the leftover divs from delete seg w/ graph layers means that it will continue take up memory after a layer is removed but this requires creating many seg layers for it to be a problem.
Additionally, creating multiple seg w/ graph layers in one session will break timesegment widget in those layers (requiring a reload to be able use them)