Dealing with a canceled Context #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethvargo
approved these changes
Jan 7, 2022
| @@ -66,6 +73,13 @@ func Do(ctx context.Context, b Backoff, f RetryFunc) error { | |||
| return rerr.Unwrap() | |||
| } | |||
|
|
|||
| // ctx.Done() has priority, so we test it alone first | |||
There was a problem hiding this comment.
If only Go had a priority for select...
Can you tell me more about this? |
|
WithJitter may produce a duration 0 when the magnitude of the jitter exceeds the duration of the "next backoff": val = 0 This case does not produce a hot loop though, because statistically there is more delay added by positive jitter, than subtracted by negative jitter. |
|
Test moved to retry_test.go |
|
This pull request has been automatically locked since there has not |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Seth, I spotted a small bug with a straightforward fix so I'm taking the liberty to make a PR without creating an issue first.
Current behaviour
NewConstantrejects a duration of0Backoff.Next()returns a duration of0, e.g. when usingWithJitterDoexecutes the user func at least once, even if the provided Context is already canceledProblems
0, it is possible that the user func gets retried, bypassing the Context cancelation check. This is because Go'sselectstatement doesn't let us specify case priority, when several cases are ready to proceed.Doshould not execute the user func at all.Fix
ctx.Done()alone, before theselectwith 2 cases.ctx.Done()before the very first call to the user func.For readability, please find 3 commits. The 1st commit is a test that usually fails, before the code fix.