Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update section about WithMaxRetries in README #4

Merged
merged 1 commit into from
Dec 2, 2021
Merged

Update section about WithMaxRetries in README #4

merged 1 commit into from
Dec 2, 2021

Conversation

wietsevenema
Copy link
Contributor

@wietsevenema wietsevenema commented Dec 2, 2021

Hi!

Thank you for this awesome library!

I was a bit confused by the section in the README about WithMaxRetries. If I understand correctly, the example would look like this?

image

This PR makes changes to reflect that in the README.

Thanks again for publishing and maintaining this!

@wietsevenema wietsevenema changed the title Update section about MaxRetries Update section about WithMaxRetries in README Dec 2, 2021
Copy link
Owner

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - yea this is a confusing topic

@sethvargo sethvargo merged commit 80daa4e into sethvargo:main Dec 2, 2021
@sethvargo
Copy link
Owner

Also I love that graphic - could you share what you used to make it?

@wietsevenema
Copy link
Contributor Author

Thank you! I made that drawing with with excalidraw

@github-actions
Copy link

This pull request has been automatically locked since there has not
been any recent activity after it was closed. Please open a new
issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants