remove subflow State type, add subFlowRef to Action #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattgarmon
force-pushed
the
removeSubflowState
branch
from
aa178fa
to
99fd7c2
Compare
Signed-off-by: mattgarmon <[email protected]>
mattgarmon
force-pushed
the
removeSubflowState
branch
from
99fd7c2
to
cb93ed1
Compare
ricardozanini
approved these changes
Aug 5, 2021
There was a problem hiding this comment.
@mattgarmon, many thanks! Now I'll have the time to go through the code to update with the 0.7 schema release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
This PR fixes "subflow" states to match what is in the specification: https://github.com/serverlessworkflow/specification/blob/main/specification.md#subflowref-definition
It removes the non-existent "subflow" State type, and adds the "subFlowRef" field to Action.
This also includes removing "workflowId" from other state types, as is is now done via Actions.
Special notes for reviewers:
Additional information (if needed):
By default the "subFlowRef" uses the full object type with "workflowId" and "version" fields, instead of the shorthand notation of just using the workflowId string. This is to be consistent with other fields which can have both string and object values.