Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go get does not get latest version of SDK #34

Closed
jjrodenburg opened this issue Jul 12, 2021 · 0 comments · Fixed by #42
Closed

Go get does not get latest version of SDK #34

jjrodenburg opened this issue Jul 12, 2021 · 0 comments · Fixed by #42
Assignees
@ricardozanini
Labels
bug 🐛 Something isn't working

Comments

@jjrodenburg
Copy link

What happened:
When doing a go get on this repo, I get version 1. When trying to pin the version to "latest", I also get version 1. Version "v2.0.0" returns a not found error. Only by using the latest commit hash was I able to get version 2 of the SDK, which is listed in the go modules as version 0:
github.com/serverlessworkflow/sdk-go v0.0.0-20210518140713-51a119677646
What you expected to happen:
go get should return version 2.

How to reproduce it:
go get github.com/serverlessworkflow/sdk-go
go get github.com/serverlessworkflow/sdk-go@latest

Anything else we need to know?:

Environment:

  • Specification version used:
    0.7
  • Go version:
    go version go1.16.5 linux/amd64
@jjrodenburg jjrodenburg added the bug 🐛 Something isn't working label Jul 12, 2021
ricardozanini added a commit to ricardozanini/sdk-go that referenced this issue Sep 23, 2021
@ricardozanini
Fix serverlessworkflow#34 - Add v2 module to go.mod
c209608 
Signed-off-by: Ricardo Zanini <[email protected]>
@ricardozanini ricardozanini mentioned this issue Sep 23, 2021
Merged
@ricardozanini ricardozanini linked a pull request Sep 23, 2021 that will close this issue
Fix #34 - Add v2 module to go.mod #42
Merged
@ricardozanini ricardozanini self-assigned this Sep 23, 2021
ricardozanini added a commit that referenced this issue Sep 23, 2021
@ricardozanini
Fix #34 - Add v2 module to go.mod (#42)
0b69af5 
* Fix #34 - Add v2 module to go.mod

Signed-off-by: Ricardo Zanini <[email protected]>

* Update README

Signed-off-by: Ricardo Zanini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardozanini ricardozanini

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #34 - Add v2 module to go.mod ricardozanini/sdk-go
2 participants
@ricardozanini @jjrodenburg