Add files #1
Add files #1
Conversation
| @@ -0,0 +1,318 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
please remove all code that is not needed for us.
src/index.js
Outdated
| { | ||
| "Effect": "Allow", | ||
| "Action": [ | ||
| "iam:GetGroupPolicy", |
There was a problem hiding this comment.
we need lambda:InvokeFunction only
src/index.js
Outdated
|
|
||
| addUserDefinition() { | ||
| _.merge(this.serverless.service.provider.compiledCloudFormationTemplate.Resources, { | ||
| "CustomCentralUser": { |
There was a problem hiding this comment.
Let's call it EventGatewayUser
src/index.js
Outdated
| "CustomCentralUser": { | ||
| "Type": "AWS::IAM::User" | ||
| }, | ||
| "CustomPolicy": { |
There was a problem hiding this comment.
Let's call it EventGatewayUserPolicy
src/index.js
Outdated
| "Type": "AWS::IAM::User" | ||
| }, | ||
| "CustomPolicy": { | ||
| "Type": "AWS::IAM::ManagedPolicy", |
There was a problem hiding this comment.
Hmm, I don't think that managed policy will work. Can you verify this?
src/index.js
Outdated
| ] | ||
| } | ||
| }, | ||
| "CustomUserKeys": { |
There was a problem hiding this comment.
Let's call it EventGatewayUserKeys
src/index.js
Outdated
| }) | ||
|
|
||
| _.merge(this.serverless.service.provider.compiledCloudFormationTemplate.Outputs, { | ||
| "AccessKey": { |
There was a problem hiding this comment.
Let's call it EventGatewayUserAccessKey
src/index.js
Outdated
| }, | ||
| "Description": "Access Key ID of Custom User" | ||
| }, | ||
| "SecretKey": { |
src/naming.js
Outdated
| @@ -0,0 +1,28 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
we probably don't need this file
Sync with the other plugin config
Updated according to the requirements
example/serverless.yml
Outdated
| @@ -0,0 +1,80 @@ | |||
| service: service-test-alerts-plugin | |||
There was a problem hiding this comment.
why alerts?
can we remove unnecessary stuff here so it will be easier to understand?
| addUserDefinition() { | ||
| _.merge(this.serverless.service.provider.compiledCloudFormationTemplate.Resources, { | ||
| "EventGatewayUser": { | ||
| "Type": "AWS::IAM::User" |
There was a problem hiding this comment.
I think we should use User's Policies fields here instead of ManagedPolicy below.
src/index.js
Outdated
| } | ||
|
|
||
| compile() { | ||
| const config = this.getConfig(); |
There was a problem hiding this comment.
if we don't need this right now, let's remove it
No description provided.