Correct laterality of the eyes landmarks ("close" #741) #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add some comments |
|
Hi, I'd be happy to comment, but I don't really know what to add here. I changed the "no result" guard, and the landmarks for the left and right eyes were permuted. You can add (GitHub) comments in the PR, where I should elaborate my changes. Regards, |
|
I added a couple of comments and these are not being resolved. Wait them all to be resolved before approving. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In #741, I noticed an error on the alignment. After further investigation, I noticed the error was in the mediapipe's wrapper. The eyes landmarks are permuted. There is head for improvement in other models (at least the one able to detect faced at any angle), like using a third poind (nose, mouth, etc.) to correctly realized the rotation.
Regards,
Vincent