Some improvements on economic security #522
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, the enforcement of the second restriction only applies to direct mints, a situation where a user directly mints sriXYZ by sending coins to its multisig address. But same out-of-pool but in system sriXYZ situation can be also achieved by on-chain swapping to it or removing liquidity from the pool without burning the received sriXYZ.
This pr doesn't apply the same restriction to those situations for now to not prevent someone from just doing a swap or removing liquidity from a pool since those are critical system functions. Also there are extra steps and hence inherent risks to those ways of achieving more sriXYZ in out-of-pool than allowed. Though those disincentives might solely be enough, it still requires further discussion and maybe thinking of other methods such as charging fees for the out-of-pool sriXYZ.