Replace python link checker with bash #216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I thought I'd give back a little, spending my open source friday time on this. I wrote a decently portable bash implementation of the existing link checker python script. It does the same sorts of things as the python script did; such as
Things this doesn't do, that the python script did:
This this does do that the python script didn't:
Really I'm hoping this script makes it a little easier for people to test the links before they upload. No installing python, creating virtual environments, installing dependencies, that sort of thing. Just run the script, done. Pretty much everyone will have bash 4, and most probably have curl installed too. No other dependencies that you wouldn't have on any linux system. I had a lot of fun writing it, I got to learn about named pipes as they were my semaphore mechanism for parallelizing the link testing :).
Actual dependencies I expect to be on `$PATH`
Windows users (I'm one of them) can still use this too, either through WSL or docker. Does the new MacOS come with bash still, or just zsh?
I also don't want to create a hurdle for people who use this repo often, so if you're interested in this, maybe it's better to reopen this PR without removing the python side of things.