bug-fix: when other user leaves, do not remove channel #937
Conversation
| @@ -66,7 +66,7 @@ function ChannelAvatar({ | |||
| alt={channel?.name} | |||
| /> | |||
| ) | |||
| ), [channel?.members, channel?.coverUrl, theme]); | |||
| ), [utils.getChannelAvatarSource(channel, userId), theme]); | |||
There was a problem hiding this comment.
Problem with prior memoization - when a user leaves a group, the channel.members array appears to be the same object reference, so even though there is 1 less member, the memoization doesn't refire even though it should
This manifested as a bug: a member who just left still accidentally appears in the ChannelAvatar (both on ChannelListUI and ChannelUI) until a page refresh occurs
There was a problem hiding this comment.
Yes correct! thanks for spotting this as well! React does not recognize changes of instance properties. We will apply your sugestion as well!
| @@ -108,28 +108,36 @@ export default function channelListReducer( | |||
| .with({ type: channelListActions.ON_USER_LEFT }, (action) => { | |||
| const { channel, isMe } = action.payload; | |||
| const { allChannels, currentUserId, currentChannel, channelListQuery, disableAutoSelect } = state; | |||
| let nextChannels = allChannels.filter((ch) => ch.url !== channel.url); | |||
There was a problem hiding this comment.
The diff here is worse than I'd like, and could be reduced if we want, but I found it much easier to reason about what was happening with an explicit top-level isMe if/else
Examples:
- if I left, we don't need to run
filterChannelListParams- we know we need to remove the channel - if someone else left, we don't need to touch
currentChannel
| // If someone else left: update allChannels if needed (don't touch currentChannel) | ||
| else { | ||
| let nextChannels = allChannels.filter((ch) => ch.url !== channel.url); | ||
| if (!channelListQuery || filterChannelListParams(channelListQuery, channel, currentUserId)) { |
There was a problem hiding this comment.
There's a change in logic here... if no channelListQuery, we should not be removing the channel (but the prior logic was incorrectly removing the channel)
There was a problem hiding this comment.
Yes you are correct, thanks for spotting this out.
|
@aldenquimby Hi thanks for providing the bug fix PR. We are onto fixing this bug and targeted to release in the next patch version, v3.10.2. Please feel free to review the PR as you wish. |
…ist when other member leaves the channel (#947) Fixes: [CLNP-2121](https://sendbird.atlassian.net/browse/CLNP-2121) ### Original PR - #937 ### Changelogs - Fixed a bug where channel is being removed from my channel list when other member leaves the channel - Fixed a bug where channel avatar image is not updated when a member leaves, or joins, or profileUrl changes Co-authored-by: @aldenquimby [CLNP-2121]: https://sendbird.atlassian.net/browse/CLNP-2121?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Baek EunSeo <[email protected]>
|
Closing this PR because the fix PR has been merged |
|
Thank you @liamcho ! Appreciate it 💪 |
bang9
added
the
Merged
steps to reproduce:
expected:
actual:
External Contributions