Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: should disable in message input wrapper view #1137

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

bang9
Copy link
Contributor

@bang9 bang9 commented Jun 17, 2024

Changes

  • Updated the logic to align with other platforms for consistency.
  • Relocated the logic to the same section where other disabled conditions are checked.

ticket: AC-2781

@bang9 bang9 self-assigned this Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 4fc8b62
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/666ff82cc2a44500093afdb1
😎 Deploy Preview https://deploy-preview-1137--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@AhyoungRyu AhyoungRyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment but LGTM :)

@bang9 bang9 merged commit a8297f6 into main Jun 17, 2024
8 checks passed
@bang9 bang9 deleted the fix/ext-input-disabled branch June 17, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants