fix: dir is not being injected in Mobile layout #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhyoungRyu
commented
Jun 13, 2024
| @@ -29,7 +29,6 @@ | |||
| @include mobile() { | |||
| min-width: 288px; | |||
| width: 100%; | |||
| padding-right: 0; | |||
There was a problem hiding this comment.
The channel creation dialog layout won't be broken even without this.
LTR
RTL
AhyoungRyu
commented
Jun 13, 2024
| useEffect(() => { | ||
| ELEMENT_IDS.forEach((id) => { | ||
| const element = document.getElementById(id); | ||
| if (element) { | ||
| element.dir = direction; | ||
| } | ||
| }); | ||
| }, [direction]); | ||
| }, [direction, isMobile]); |
There was a problem hiding this comment.
isMobile is determined within useMediaQueryContext, and this needs to run separately of the useApplyTextDirection hook. This ensures that the internal logic of the useApplyTextDirection hook is executed only after the isMobile value has been properly set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.