-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLNP-3692] Apply postcss-rtlcss plugin for RTL support #1134
Conversation
fbb2ec7
to
cd9ecc5
Compare
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
SwitchAnimation direction might need to be changed 2024-06-13.9.22.40.mov |
TextInput + MentionIt would be good to check how mentions work in RTL as the standard 2024-06-13.9.24.58.mov |
Amazing plugin! |
@bang9 Great. Thanks for checking the details. Let me check and update :) |
So I made some fixes for these
|
I'm merging this into the base branch #1132 🚀 |
Applied [postcss-rtlcss plugin](https://github.com/elchininet/postcss-rtlcss) for the better RTL support without tedious manual CSS style modifications. - [x] Added plugin configuration to storybook/main.ts - Allows testing of RTL support during development. - [x] Added plugin configuration to rollup.config.js - Ensures build artifacts support RTL languages. - [x] Created useHTMLTextDirection custom hook - Applies the dir attribute to modal and dropdown portal components for correct RTL rendering. postcss-rtlcss automates the conversion of LTR CSS to RTL, ensuring consistency and reducing manual errors. It automates CSS transformation by converting LTR styles to RTL, ensuring proper alignment and display in RTL mode. You can play around in here https://elchininet.github.io/postcss-rtlcss/ to see what kind of modifications could be made by this plugin.
To address https://sendbird.atlassian.net/browse/CLNP-3692, applied postcss-rtlcss plugin for the better RTL support without tedious manual CSS style modifications.
What has been done?
Why postcss-rtlcss Plugin?
postcss-rtlcss automates the conversion of LTR CSS to RTL, ensuring consistency and reducing manual errors.
It automates CSS transformation by converting LTR styles to RTL, ensuring proper alignment and display in RTL mode.
You can play around in here https://elchininet.github.io/postcss-rtlcss/ to see what kind of modifications could be made by this plugin.