Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLNP-3254] feat: support descriptive color name #1129

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

AhyoungRyu
Copy link
Contributor

Addresses https://sendbird.atlassian.net/browse/CLNP-3254

Change Description

image

Users who want to customize the color set can use below new more descriptive color name instead of 001 / 002 ... 005. I added a color map parsing util function; mapColorKeys to ,a the new & existing color name but we'll be still using the existing names. Refer to this Slack thread for more detailed discussion.

  1. Primary, Secondary, Error, information
Primary-500 -> Primary-extra dark
Primary-400 -> Primary-dark
Primary-300 -> Primary-main
Primary-200 -> Primary-light
Primary-100 -> Primary-extra light

Secondary-500 -> Secondary-extra dark
Secondary-400 -> Secondary-dark
Secondary-300 -> Secondary-main
Secondary-200 -> Secondary-light
Secondary-100 -> Secondary-extra light
  1. Background 100~700: No changes

  2. Overlay

Overlay-01 -> Overlay-dark
Overlay-02 -> Overlay-light
  1. OnLight & OnDark
// On Light
On Light-01 -> Onlight-text-high-emphasis
On Light-02 -> Onlight-text-mid-emphasis
On Light-03 -> Onlight-text-low-emphasis
On Light-04 -> Onlight-text-disabled
// On Dark
On Dark -01 -> Ondark-text-high-emphasis
On Dark -02 -> Ondark-text-mid-emphasis
On Dark -03 -> Ondark-text-low-emphasis
On Dark -04 -> Ondark-text-disabled

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit dd8a0a7
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/6666919e82ab2c00080fcb0f
😎 Deploy Preview https://deploy-preview-1129--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 715c752
🔍 Latest deploy log https://app.netlify.com/sites/sendbird-uikit-react/deploys/6671045b25914100080aca3a
😎 Deploy Preview https://deploy-preview-1129--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@chrisallo chrisallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/lib/utils/colorMapper.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@HoonBaek HoonBaek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left minor comments related to the mapColorKey. LGTM.

@AhyoungRyu AhyoungRyu merged commit ddf3ada into main Jun 18, 2024
8 checks passed
@AhyoungRyu AhyoungRyu deleted the feat/CLNP-3254/color-rename branch June 18, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants