-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CLNP-3087): message threading #181
base: main
Are you sure you want to change the base?
Conversation
d6b7734
to
1727b18
Compare
packages/uikit-react-native-foundation/src/ui/GroupChannelMessage/MessageContainer.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native-foundation/src/ui/GroupChannelMessage/MessageContainer.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/components/GroupChannelMessageRenderer/index.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/localization/createBaseStringSet.ts
Outdated
Show resolved
Hide resolved
...react-native/src/domain/groupChannelThread/component/GroupChannelThreadParentMessageInfo.tsx
Outdated
Show resolved
Hide resolved
...react-native/src/domain/groupChannelThread/component/GroupChannelThreadParentMessageInfo.tsx
Outdated
Show resolved
Hide resolved
...kit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageReplyInfo.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/components/ChannelInput/index.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/components/ChannelMessageList/index.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/domain/groupChannelThread/module/moduleContext.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/domain/groupChannelThread/module/moduleContext.tsx
Outdated
Show resolved
Hide resolved
packages/uikit-react-native-foundation/src/ui/GroupChannelMessage/MessageContainer.tsx
Outdated
Show resolved
Hide resolved
...t-react-native/src/components/ThreadParentMessageRenderer/ThreadParentMessage.file.voice.tsx
Show resolved
Hide resolved
packages/uikit-react-native/src/domain/groupChannelThread/types.ts
Outdated
Show resolved
Hide resolved
packages/uikit-react-native/src/domain/groupChannelThread/types.ts
Outdated
Show resolved
Hide resolved
<GroupChannelThreadModule.ParentMessageInfo | ||
channel={channel} | ||
currentUserId={currentUser?.userId} | ||
onDeleteMessage={deleteMessage} | ||
onPressMediaMessage={_onPressMediaMessage} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 안드로이드에서는 ScrollView 안에 ParentMessageInfo
가 있네요
memoizedFlatListProps
에 ListFooterComponent: <GroupChannelThreadModule.ParentMessageInfo />
로 넣으면 되긴 하는데, 일단 QA 가서 버그로 나오면 수정 가시죠~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은정보 감사드립니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 잠깐 테스트해봤는데 메세지가 없거나 적을때 상단고정이 안되네요 뭔가 방법이있을것 같은데 추후에 수정할때 확인해보겠습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 내용을 제가 잘못 이해 했네요. 동작 자체가 다른 플랫폼이랑 다르게 되고있었네요
ChannelMessageList, ChatFlatList 가 일반채널 메세지리스트에 특화되어 처리되고있는것 같아
다음과 같이 수정하였습니다.
- ChannelThreadMessageList 를 추가
- Props 에서 불필요한 부분을 제거
- prevMessage, nextMessage 메세지 인덱스 변경
- ChatFlatList 수정
- 리스트의 메세지가 무조건 아래부터 보이도록 하는부분을 inverted 기준 위에서부터 보일수있도록 수정
- onScrolledAwayFromBottom 호출되는 조건 처리 수정
- memoizedFlatListProps 에서 ListHeaderComponent에 <GroupChannelThreadModule.ParentMessageInfo/> 추가
packages/uikit-react-native/src/domain/groupChannelThread/types.ts
Outdated
Show resolved
Hide resolved
...react-native/src/domain/groupChannelThread/component/GroupChannelThreadParentMessageInfo.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요거 ParentMessageInfo가 MessageList로 변경되면서 추가로 수정 안해도 될것 같습니다 |
47fa998
to
7e80e69
Compare
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
uikit-tools 패키지에 기능이 추가되어 uikit-core-ts 배포이후 package 버전 올려야 정상 동작합니다[CLNP-3087](https://sendbird.atlassian.net/browse/CLNP-3087)
Description Of Changes
Thread UI 추가
쓰레드 ParentMessage 종류별로 추가
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_