Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CLNP-3087): message threading #181

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented May 30, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

uikit-tools 패키지에 기능이 추가되어 uikit-core-ts 배포이후 package 버전 올려야 정상 동작합니다
[CLNP-3087](https://sendbird.atlassian.net/browse/CLNP-3087)

Description Of Changes

  • 그룹채널 메세지 thread 관련 정보 추가(GroupChannelMessageReplyInfo.tsx)
Screenshot 2024-05-30 at 11 37 17 AM
  • Thread UI 추가

    • createGroupChannelThreadFragment.tsx
    • GroupChannelThreadScreen.tsx
    • groupChannelThread(Directory)
  • 쓰레드 ParentMessage 종류별로 추가

    • ThreadParentMessage.file.image.tsx
    • ThreadParentMessage.file.tsx
    • ThreadParentMessage.file.video.tsx
    • ThreadParentMessage.file.voice.tsx
    • ThreadParentMessage.user.og.tsx
    • ThreadParentMessage.user.tsx
Screenshot 2024-05-30 at 3 06 39 PM Screenshot 2024-05-30 at 3 08 18 PM Screenshot 2024-05-30 at 3 08 29 PM Screenshot 2024-05-30 at 3 04 42 PM Screenshot 2024-05-30 at 3 04 50 PM Screenshot 2024-05-30 at 3 05 19 PM Screenshot 2024-05-30 at 3 06 02 PM Screenshot 2024-05-30 at 3 07 08 PM Screenshot 2024-05-30 at 3 06 39 PM

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0.26178% with 762 lines in your changes missing coverage. Please review.

Project coverage is 11.93%. Comparing base (3836c10) to head (7e80e69).

Files Patch % Lines
.../src/components/ChannelThreadMessageList/index.tsx 0.00% 115 Missing ⚠️
.../component/GroupChannelThreadParentMessageInfo.tsx 0.00% 102 Missing ⚠️
...src/fragments/createGroupChannelThreadFragment.tsx 0.00% 95 Missing ⚠️
...c/components/ThreadParentMessageRenderer/index.tsx 0.00% 85 Missing ⚠️
...domain/groupChannelThread/module/moduleContext.tsx 0.00% 49 Missing ⚠️
...Thread/component/GroupChannelThreadMessageList.tsx 0.00% 41 Missing ⚠️
...mponent/GroupChannelThreadSuggestedMentionList.tsx 0.00% 29 Missing ⚠️
...MessageRenderer/ThreadParentMessage.file.voice.tsx 0.00% 24 Missing ⚠️
...entMessageRenderer/ThreadParentMessage.user.og.tsx 0.00% 23 Missing ⚠️
...elMessageRenderer/GroupChannelMessageReplyInfo.tsx 0.00% 19 Missing ⚠️
... and 22 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   13.07%   11.93%   -1.15%     
==========================================
  Files         334      353      +19     
  Lines        7434     8161     +727     
  Branches     1919     2148     +229     
==========================================
+ Hits          972      974       +2     
- Misses       6461     7186     +725     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OnestarLee OnestarLee requested a review from bang9 May 30, 2024 07:16
@bang9 bang9 changed the title Feat(CLNP-3087): message threading feat(CLNP-3087): message threading May 31, 2024
@OnestarLee OnestarLee self-assigned this May 31, 2024
@OnestarLee OnestarLee requested a review from bang9 May 31, 2024 07:34
@OnestarLee OnestarLee requested a review from bang9 May 31, 2024 08:34
Comment on lines 196 to 201
<GroupChannelThreadModule.ParentMessageInfo
channel={channel}
currentUserId={currentUser?.userId}
onDeleteMessage={deleteMessage}
onPressMediaMessage={_onPressMediaMessage}
/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 안드로이드에서는 ScrollView 안에 ParentMessageInfo 가 있네요
memoizedFlatListPropsListFooterComponent: <GroupChannelThreadModule.ParentMessageInfo /> 로 넣으면 되긴 하는데, 일단 QA 가서 버그로 나오면 수정 가시죠~!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은정보 감사드립니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 잠깐 테스트해봤는데 메세지가 없거나 적을때 상단고정이 안되네요 뭔가 방법이있을것 같은데 추후에 수정할때 확인해보겠습니다

Copy link
Collaborator Author

@OnestarLee OnestarLee Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요거 내용을 제가 잘못 이해 했네요. 동작 자체가 다른 플랫폼이랑 다르게 되고있었네요
ChannelMessageList, ChatFlatList 가 일반채널 메세지리스트에 특화되어 처리되고있는것 같아
다음과 같이 수정하였습니다.

  • ChannelThreadMessageList 를 추가
    • Props 에서 불필요한 부분을 제거
    • prevMessage, nextMessage 메세지 인덱스 변경
  • ChatFlatList 수정
    • 리스트의 메세지가 무조건 아래부터 보이도록 하는부분을 inverted 기준 위에서부터 보일수있도록 수정
    • onScrolledAwayFromBottom 호출되는 조건 처리 수정
  • memoizedFlatListProps 에서 ListHeaderComponent에 <GroupChannelThreadModule.ParentMessageInfo/> 추가

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗~ 가로모드 깜빡했네요 ParentMessageInfo 컴포넌트에만 적용되면 될거같아요.
useSafeAreaInsets(); 사용되는 부분들 참고하셔서 left, right 에 여백 추가로 주시면 됩니다!

simulator_screenshot_D3D51694-F75C-46D7-A27C-01669ECE598E

@OnestarLee
Copy link
Collaborator Author

앗~ 가로모드 깜빡했네요 ParentMessageInfo 컴포넌트에만 적용되면 될거같아요. useSafeAreaInsets(); 사용되는 부분들 참고하셔서 left, right 에 여백 추가로 주시면 됩니다!

요거 ParentMessageInfo가 MessageList로 변경되면서 추가로 수정 안해도 될것 같습니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants