Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SendbirdChatSDK #93

Merged
merged 2 commits into from
Apr 7, 2022
Merged

Update SendbirdChatSDK #93

merged 2 commits into from
Apr 7, 2022

Conversation

cozzin
Copy link
Contributor

@cozzin cozzin commented Apr 5, 2022

The product name of the chat framework is changed.
After merging this PR, we should import the module as SendbirdChatSDK.

@cozzin cozzin requested a review from YogeshVeer April 5, 2022 07:24
@cozzin cozzin self-assigned this Apr 5, 2022
@YogeshVeer
Copy link
Contributor

It seems meanwhile there are 3 other feature sample has been merged. How do we proceed? Either we keep the latest merge and update with this PR or i should wait for this merge and update the changes in another branch.

@chrischabot
Copy link
Contributor

@cozzin can you advice on the approach @YogeshVeer could take here?

Could we save this as a .diff and manually patch it into the new samples?

@cozzin
Copy link
Contributor Author

cozzin commented Apr 7, 2022

It seems meanwhile there are 3 other feature sample has been merged. How do we proceed? Either we keep the latest merge and update with this PR or i should wait for this merge and update the changes in another branch.

I rebased based on the main branch and updated SDK for added features, and I also rebase #95 based on main branch.

@cozzin cozzin merged commit 0ab9391 into main Apr 7, 2022
@cozzin cozzin deleted the feature/update-sdk branch April 7, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants