Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update render feedback rule based on myFeedbackStatus #260

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

liamcho
Copy link
Contributor

@liamcho liamcho commented Jun 3, 2024

Changelog

  • Message feedback buttons are displayed if and only if message.myFeedbackStatus is not 'NOT_APPLICABLE'

Ticket

https://sendbird.atlassian.net/browse/AC-2290

discussion:
https://sendbird.slack.com/archives/C0585965FFA/p1717402133967919?thread_ts=1717121915.460269&cid=C0585965FFA

@liamcho liamcho added the 1.6.2 label Jun 3, 2024
@liamcho liamcho requested a review from bang9 June 3, 2024 08:38
@liamcho liamcho self-assigned this Jun 3, 2024
Copy link
Contributor

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check if it is working properly with the patched chat-sdk before requesting a review?

@liamcho
Copy link
Contributor Author

liamcho commented Jun 3, 2024

let me test this tomorrow. I need to figure out how to enable/disable feedback in server. It should be done by request at init step.

@bang9
Copy link
Contributor

bang9 commented Jun 3, 2024

let me test this tomorrow. I need to figure out how to enable/disable feedback in server. It should be done by request at init step.

You can check the detailed policy for feedback here: https://docs.google.com/document/d/1M06574UQU3NV-fucbP6HCf1oCvxYyBWC_ETOISrvLQ4/edit (it's included in thread)

@liamcho
Copy link
Contributor Author

liamcho commented Jun 4, 2024

@bang9 the fix has been confirmed through testing!
https://sendbird.slack.com/archives/C0585965FFA/p1717473239686719?thread_ts=1717121915.460269&cid=C0585965FFA

@bang9
Copy link
Contributor

bang9 commented Jun 4, 2024

I have confirmed that it works well in self-service too.

@liamcho
Copy link
Contributor Author

liamcho commented Jun 4, 2024

@bang9 thanks for testing self-servce. When you have time, can you please share how to test self-service?
I tried running locally by swapping to local project but failed to do it.

    "@sendbird/chat-ai-widget": "file:/Users/liamcho/GitHub/chat-ai-widget/dist",
    
 ➜  self-service git:(develop) ✗ yarn install
➤ YN0000: · Yarn 4.2.2
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @sendbird/chat-ai-widget@file:/Users/liamcho/GitHub/chat-ai-widget/dist#/Users/liamcho/GitHub/chat-ai-widget/dist::hash=c5affd&locator=self-service%40workspace%3Apackages%2Fself-service: Manifest not found

I will document the SOP for others too!

@liamcho liamcho requested a review from bang9 June 4, 2024 07:13
@bang9
Copy link
Contributor

bang9 commented Jun 4, 2024

I'll approve it once the chat-sdk is updated.

@bang9
Copy link
Contributor

bang9 commented Jun 4, 2024

@bang9 thanks for testing self-servce. When you have time, can you please share how to test self-service? I tried running locally by swapping to local project but failed to do it.

    "@sendbird/chat-ai-widget": "file:/Users/liamcho/GitHub/chat-ai-widget/dist",
    
 ➜  self-service git:(develop) ✗ yarn install
➤ YN0000: · Yarn 4.2.2
➤ YN0000: ┌ Resolution step
➤ YN0001: │ Error: @sendbird/chat-ai-widget@file:/Users/liamcho/GitHub/chat-ai-widget/dist#/Users/liamcho/GitHub/chat-ai-widget/dist::hash=c5affd&locator=self-service%40workspace%3Apackages%2Fself-service: Manifest not found

I will document the SOP for others too!

I will inform you from a fundamental perspective tomorrow.

@bang9 bang9 added Pending and removed Pending labels Jun 4, 2024
@bang9
Copy link
Contributor

bang9 commented Jun 5, 2024

https://github.com/sendbird/sendbird-chat-sdk-javascript/releases/tag/v4.12.7

@liamcho
Copy link
Contributor Author

liamcho commented Jun 7, 2024

@bang9 Please review sendbird/sendbird-uikit-react#1125, thanks!

@liamcho
Copy link
Contributor Author

liamcho commented Jun 7, 2024

@bang9 all good!
tested with "@sendbird/chat": "^4.12.7",
in packages/uikit package.json

video1414155140.mp4

@bang9
Copy link
Contributor

bang9 commented Jun 7, 2024

great, could you update the head of submodule?

@liamcho liamcho merged commit 01dfc75 into develop Jun 7, 2024
@liamcho liamcho deleted the fix/AC-2290-update-render-feedback-rule branch June 7, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants