-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Suppliers to DX #2581
Migrate Suppliers to DX #2581
Conversation
…const for address type
Hi @ramonski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @Bugerman58 ! I've left some comments, keep it going!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that addresses were partially migrated, see comments. We are almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks @Bugerman58 !
Running the same upgrade step once again raises a traceback:
@Bugerman58: Would you mind to create a new PR to handle this gracefully? |
Hi @ramonski oh, sure. I'll fix this error soon |
Description of the issue/feature this PR addresses
This PR migrates the AT Supplier and Suppliers to Dexterity types for Python 3 compatibility.
Current behavior before PR
Supplier and Suppliers are content types based on the Archetypes framework
Desired behavior after PR is merged
Supplier and Suppliers are content types based on the Dexterity framework
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.