-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate LabProducts to DX #2574
Conversation
@ramonski pls, review ) |
@xispa: We need to decide how to best continue with these Lab Products. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Leonid, you are becoming migration pro's already:)
Some minor changes only for data consistency in the DB.
@ramonski I think I fixed it )) (just dont know did it notify you or not ) |
From my point of view, we can get rid of them. I think these Lab Products are not being used by anybody. And in any case, they would fit better in an another add-on, with probably other functionalities related with inventory and the like. |
Ok, let's decide on that later. I would like to have at least the DX port in core to make use of this code when we might refactor it into a separate add-on. |
ahahah ))) that's was my best shot to make clean migration ever (I'm still learning). But anyway I agree with you guys :) no reason to keep useless code in the core module. |
We're definitely using the code you created, because it allows us to simply use it when we port it out of the core in a separate add-on. We might consider in a separate PR to hide it from the LIMS SETUP to not confuse the users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Leonid, works perfectly!
Thanks @toropok ! |
Description of the issue/feature this PR addresses
This PR migrates the AT LabProduct to Dexterity types for Python 3 compatibility.
Current behavior before PR
LabProduct content type based on the Archetypes framework
Desired behavior after PR is merged
LabProduct is content types base on the Dexterity framework
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.