Cleanup stale indexes and metadata columns #2335
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
approved these changes
Jun 24, 2023
| } | ||
|
|
||
| portal = api.get_portal() | ||
| for obj in portal.objectValues(): |
There was a problem hiding this comment.
Make it better explicit instead of iterating over all objects in the portal, e.g.:
base_catalog_idxs = ["CreationDate", ]
for cat_id, idxs in indexes_to_remove.items():
cat = api.get_tool(cat_id)
if isinstance(cat, BaseCatalog):
idxs.extend(base_catalog_idxs)
...
|
This PR is marked as |
|
Would you mind to resolve the conflicts of this PR and check if everything is still valid with the new catalogs? |
ramonski
requested changes
Oct 14, 2023
| @@ -143,22 +143,9 @@ def __init__(self, context, request): | |||
| "toggle": True}), | |||
| ("ClientID", { | |||
| "title": _("Client ID"), | |||
| "index": "getClientID", | |||
There was a problem hiding this comment.
Why did you remove this Index? Without this it is no longer possible to sort the columns by client ID.
There was a problem hiding this comment.
Thanks for the heads-up. Restored with 1b6e61d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Merge #2334 first
This Pull Request removes indexes and metadata columns that are no longer needed
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.