Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ntrip client fixes #6 #7

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

Fix gnssntripclient issue where blank lines in HTTP sourcetable response from NTRIP caster could prevent sourcetable being retrieved and processed.

Fixes #6

Testing

Please test all changes, however trivial, against the supplied unittest suite tests/test_*.py e.g. by executing the tests/testsuite.py module or using your IDE's native Python unittest integration facilities. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Tested against NTRIP casters specified in issue report

Checklist:

  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Oct 17, 2022
@semuadmin semuadmin self-assigned this Oct 17, 2022
@semuadmin semuadmin merged commit 2563bbc into main Oct 17, 2022
@semuadmin semuadmin deleted the enhance-NTRIP-client-fixes-#6 branch October 17, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to receive mountpoints from some servers
1 participant