Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.0.28 #68

Merged
merged 5 commits into from
Jun 4, 2024
Merged

Rc 1.0.28 #68

merged 5 commits into from
Jun 4, 2024

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

  1. Fix waittime in ubxload - thanks to @hugokernel for contribution.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

hugokernel and others added 3 commits May 29, 2024 15:01
Since the default value will always be well below the current time + waittime, waittime will always be ignored.
@semuadmin semuadmin added the bug Something isn't working label May 29, 2024
@semuadmin semuadmin added this to the RC 1.0.28 milestone May 29, 2024
@semuadmin semuadmin self-assigned this May 29, 2024
@semuadmin semuadmin marked this pull request as draft May 29, 2024 15:57
@semuadmin semuadmin marked this pull request as ready for review June 4, 2024 18:54
@semuadmin semuadmin merged commit 572c75e into main Jun 4, 2024
@semuadmin semuadmin deleted the RC-1.0.28 branch June 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants