Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RELEASE CANDIDATE 1.0.23 #61

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

FIXES:

  1. Fix to socket_server NTRIP caster source table HTTP response which was causing some NTRIP clients to timeout.

Fixes #60

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Tested on Windows, MacOS & Linux using a variety of NTRIP clients

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the bug Something isn't working label Apr 11, 2024
@semuadmin semuadmin added this to the 1.0.23 milestone Apr 11, 2024
@semuadmin semuadmin self-assigned this Apr 11, 2024
@semuadmin semuadmin requested a review from a team April 11, 2024 17:10
@semuadmin semuadmin merged commit 56a68ca into main Apr 11, 2024
@semuadmin semuadmin deleted the fix-NTRIP-caster-HTTP-header-issue branch April 11, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improperly Formatted NTRIP sourcetable response
2 participants