Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc 1.0.12 #37

Merged
merged 11 commits into from
Aug 3, 2023
Merged

Rc 1.0.12 #37

merged 11 commits into from
Aug 3, 2023

Conversation

semuadmin
Copy link
Contributor

pygnssutils Pull Request Template

Description

RELEASE 1.0.12

CHANGES:

  1. Add ntripuser and ntrippassword keyword arguments to SockerServer, GNSSSockerServer and GNSSNTRIPClient classes for use in NTRIP Caster authentication. If not supplied, these will default to environment variables PYGPSCLIENT_USER and PYGPSCLIENT_PASSWORD or, failing that, "anon" and "password".
  2. NB: This will require a corresponding update to PyGPSClient (>=1.4.0).
  3. NB: These arguments were previously named user and password in GNSSSockerServer and GNSSNTRIPClient classes - any scripts instantiating either of these classes will require updating.
  4. Updated minimum version dependency for pyubx2 (1.2.29)

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Added tests for ntripuser args

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin self-assigned this Aug 3, 2023
@semuadmin semuadmin added the enhancement New feature or request label Aug 3, 2023
@semuadmin semuadmin requested a review from a team August 3, 2023 07:08
@semuadmin semuadmin merged commit 7487168 into main Aug 3, 2023
@semuadmin semuadmin deleted the RC-1.0.12 branch August 3, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants