Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyGPSClient Pull Request Template
Description
RELEASE CANDIDATE 1.3.2
CHANGES:
serial_handler.py
andsocket_handler.py
into singlestream_handler.py
module, utilising the latestpyubx2.UBXReader
andpyubx2.SocketStream
functionality for common reading and parsing of all data streams including socket. Affords significant reduction in code duplication betweenPyGPSClient
andpyubx2
, as well as substantially mitigating issues with automated testing of parsing routines in PyGPSClient (GitHub Actions workflow does not support tkinter), as these routines can be fully tested inpyubx2
.stream_handler.py
andntrip_handler.py
.FIXES:
Fixes # (issue)
Testing
Please test all changes, however trivial, against the supplied unittest suite
tests/test_*.py
e.g. by executing thetests/testsuite.py
module or using your IDE's native Python unittest integration facilities. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.Checklist:
CONTRIBUTING.MD
).tests/test_*.py
unittest suite to maintain >= 99% code coverage.tests/test_*.py
unittest suite.