Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common pyubx2 parser #24

Merged
merged 17 commits into from
May 8, 2022
Merged

Use common pyubx2 parser #24

merged 17 commits into from
May 8, 2022

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented May 8, 2022

PyGPSClient Pull Request Template

Description

RELEASE CANDIDATE 1.3.2

CHANGES:

  1. Extensive internal refactoring of serial_handler.py and socket_handler.py into single stream_handler.py module, utilising the latest pyubx2.UBXReader and pyubx2.SocketStream functionality for common reading and parsing of all data streams including socket. Affords significant reduction in code duplication between PyGPSClient and pyubx2, as well as substantially mitigating issues with automated testing of parsing routines in PyGPSClient (GitHub Actions workflow does not support tkinter), as these routines can be fully tested in pyubx2.
  2. Minor improvements in thread handling in stream_handler.py and ntrip_handler.py.
  3. Minimum versions of pyubx2 and pynmeagps updated to 1.2.9 and 1.0.11 respectively.

FIXES:

  1. Preset message rate commands now set rates on ALL ports including UART2 (UART2 was previously omitted).

Fixes # (issue)

Testing

Please test all changes, however trivial, against the supplied unittest suite tests/test_*.py e.g. by executing the tests/testsuite.py module or using your IDE's native Python unittest integration facilities. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin self-assigned this May 8, 2022
@semuadmin semuadmin added the enhancement New feature or request label May 8, 2022
@semuadmin semuadmin requested a review from semudev2 May 8, 2022 09:19
@semuadmin semuadmin merged commit d6a8d37 into master May 8, 2022
@semuadmin semuadmin deleted the use-common-pyubx2-parser branch May 8, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants