Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NTRIP client functionality #16

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

semuadmin
Copy link
Contributor

PyGPSClient Pull Request Template

Description

Add beta NTRIP client functionality to v1.1.9. New NTRIP client configuration dialog which allows user to connect to specified NTRIP caster, retrieve sourcetable, select mountpoint, receive RTCM3 correction messages and upload NMEA GGA sentences at selected intervals. Enhancements to app, nmea handler and ubx handler to retain latest navigation readings in global settings dictionary.

Fixes # (issue)

Testing

Please test all changes, however trivial, against the supplied unittest suite tests/test_*.py e.g. by executing the tests/testsuite.py module or using your IDE's native Python unittest integration facilities. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

  • Tested against variety of public NTRIP servers and u-blox GNSS devices.

Checklist:

  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin self-assigned this Apr 6, 2022
@semuadmin semuadmin added the enhancement New feature or request label Apr 6, 2022
@semuadmin semuadmin requested a review from semudev2 April 6, 2022 08:13
Copy link
Contributor

@semudev2 semudev2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Same socket engine as pyrtcm ntripclient.py example which was simple and solid.

@semuadmin semuadmin merged commit 15a41c7 into master Apr 6, 2022
@semuadmin semuadmin deleted the NTRIP_client_functionality branch April 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants