Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate 1.4.8 #108

Merged
merged 5 commits into from
Jan 18, 2024
Merged

Release candidate 1.4.8 #108

merged 5 commits into from
Jan 18, 2024

Conversation

semuadmin
Copy link
Contributor

PyGPSClient Pull Request Template

RELEASE CANDIDATE 1.4.8

FIXES:

  1. Fix parsing of command line arguments (NB: command line arguments and/or environment variables will now take temporary precedence over saved config file settings)
  2. Fix 'unhashable type' error when first displaying mountpoint data in NTRIP client panel

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.MD).
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain test coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin self-assigned this Jan 18, 2024
@semuadmin semuadmin added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 18, 2024
@semuadmin semuadmin requested a review from a team January 18, 2024 13:41
@semuadmin semuadmin added this to the RC 1.4.8 milestone Jan 18, 2024
@semuadmin semuadmin merged commit c9a4117 into master Jan 18, 2024
@semuadmin semuadmin deleted the RELEASE-CANDIDATE-1.4.8 branch January 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants