Better inverses #1021
Better inverses #1021
Conversation
…or the argument of RightGreensMultiplierNC.
…e is no one but the method should work
james-d-mitchell
added
performance
Co-authored-by: James Mitchell <[email protected]>
Co-authored-by: James Mitchell <[email protected]>
gap/greens/froidure-pin.gi
Outdated
| if path = fail then | ||
| # This can occur when, for example, a = b and S is not a monoid. | ||
| return One(gens); | ||
| if IsMultiplicativeElement(a) and IsMultiplicativeElement(b) then |
There was a problem hiding this comment.
I don't think this does exactly what you want it to, maybe you meant not IsMultiplicativeElementWithOne(a) and similar for b?
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Still missing, and the documentation for Left/RightGreensMultiplier should be updated to include:
If S is a semigroup but not a monoid, then the return value is either of the same type as the elements of S or an adjoined identity.
There was a problem hiding this comment.
Missing "WithOne" fixed. The documentation is possibly more delicate than that, as an fp semigroup can be a monoid but GAP cannot recognise it as one. One example is < s1, s2 | s1^2=s1, s2^2=s2, s1s2=s2, s2s1=s2>. s1 is a "one" but GAP does not know that.
gap/greens/froidure-pin.gi
Outdated
| if IsMultiplicativeElement(a) and IsMultiplicativeElement(b) then | ||
| return One(gens); | ||
| else | ||
| return SEMIGROUPS.UniversalFakeOne; |
There was a problem hiding this comment.
Probably should add some tests for this too?
…to better-inverses
Co-authored-by: James Mitchell <[email protected]>
Co-authored-by: James Mitchell <[email protected]>
Co-authored-by: James Mitchell <[email protected]>
Co-authored-by: James Mitchell <[email protected]>
…to better-inverses
gap/greens/froidure-pin.gi
Outdated
| if path = fail then | ||
| # This can occur when, for example, a = b and S is not a monoid. | ||
| return One(gens); | ||
| if IsMultiplicativeElement(a) and IsMultiplicativeElement(b) then |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
currently no test for finding inverse of a semigroup that cannot use Froidure-Pin. |
| <Description> | ||
| <C>OneInverseOfSemigroupElement</C> returns one inverse of the element | ||
| <C>x</C> in the semigroup <A>S</A>. | ||
| </Description> |
found one using Semigroup(SEMIGROUPS.UniversalFakeOne). Resolved |
doc/attr.xml
Outdated
| <Returns> One inverse of an element of a semigroup.</Returns> | ||
| <Description> | ||
| <C>OneInverseOfSemigroupElement</C> returns one inverse of the element | ||
| <C>x</C> in the semigroup <A>S</A>. |
There was a problem hiding this comment.
What happens if there is no inverse?
Co-authored-by: James Mitchell <[email protected]>
Add a better method for finding inverses of a multiplicative element of a semigroup that can use Froidure-Pin.
Also add a new method called OneInverseOfSemigroupElement.