Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pseudo-state button styling in theming docs #1635

Merged

Conversation

ibrahimpg
Copy link
Contributor

Overview
Theming docs examples are currently missing the selectors property that pseudo state styling is meant to be nested inside of

Screenshots (if applicable)
beforeafter

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for evergreen-storybook ready!

Name Link
🔨 Latest commit ea747e9
🔍 Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/6433cf190350cd0008f8cd55
😎 Deploy Preview https://deploy-preview-1635--evergreen-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@brandongregoryscott brandongregoryscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@brandongregoryscott brandongregoryscott merged commit 0a89c2b into segmentio:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants