Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README updates for the main repo, and a light overview on the docs subdir #1202

Merged
merged 2 commits into from
May 18, 2021

Conversation

akleiner2
Copy link
Contributor

Overview
Updating some links now that the new evergreen.segment.com is live.

Screenshots (if applicable)
N/A

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@akleiner2 akleiner2 requested a review from kamebkj May 17, 2021 23:06
@@ -218,4 +213,4 @@ Please respect our [Code of Conduct](.github/CODE_OF_CONDUCT.md), in short:
Evergreen is released under the MIT license.
The BlueprintJS icons are licensed under a [custom Apache 2.0 license](https://github.com/palantir/blueprint/blob/develop/LICENSE).

Copyright © 2017 Segment.io, Inc.
Copyright © 2021 Segment.io, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@kamebkj kamebkj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one minor call out on thumbnail image. otherwise lgtm!


When we run `next dev` the next time, Next.js will start looking for any `.ts` or `.tsx` files in our project and builds it. It even automatically creates a `tsconfig.json` file for our project with the recommended settings.
From there, the directory structure in `docs/documentation/` contains the `.mdx` files which mirror the route structure for the docs site.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we also want to call out adding thumbnail images and add them to public

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! We can always come back here and just link to the next.js documentation. We're not doing anything fancy other than using the standard filesystem setup.

@akleiner2
Copy link
Contributor Author

Need to figure out why the actions keep getting cancelled, but given that this is a documentation change, it should be fine.

@akleiner2 akleiner2 merged commit 23389eb into master May 18, 2021
@akleiner2 akleiner2 deleted the fix-readme branch May 18, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants