Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier across the codebase, and add prettier --check to CI #1122

Merged
merged 6 commits into from
Dec 4, 2020

Conversation

akleiner2
Copy link
Contributor

Overview
To prevent git churn in PRs, we should be running prettier and prettier check across the entire codebase. This PR adds these checks to CI. Our build times will slow a bit (I think this becomes the bottleneck step) , but at least we'll have consistency going forward.

Screenshots (if applicable)

Documentation

  • Updated Typescript types and/or component PropTypes
  • Added / modified component docs
  • Added / modified Storybook stories

@akleiner2 akleiner2 merged commit 9fe0465 into master Dec 4, 2020
@akleiner2 akleiner2 deleted the run-prettier-and-add-prettier-check branch December 4, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants