Remove dom-helpers, add local lib/canUseDom #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshwery
reviewed
Sep 25, 2020
tggreene
changed the title
tggreene
commented
Oct 5, 2020
docs/src/components/TopBar.js
Outdated
| @@ -6,7 +6,7 @@ import GitHubButton from 'react-github-button' | |||
| import GitHubIcon from './GitHubIcon' | |||
| import SpectrumIcon from './SpectrumIcon' | |||
| import LogoWordmark from './LogoWordmark' | |||
| // eslint-disable-next-line import/no-unassigned-import | |||
| // eslint-disable-next-line import/no-unassigned-import, import/extensions | |||
There was a problem hiding this comment.
welp, look at me thinking I'm being clever
|
I think this is ready for a recheck. I think I bumped into a cached dependency difference with xo with respect to the above failure! I think when the dependency cache is killed this guy will flare up 👉 xojs/xo@d3abdb6. This change turned out to be quite noddy in the end, but appreciate your consideration all the same! |
mshwery
reviewed
Oct 6, 2020
Remove an unneeded dependency on dom-helpers and simply add a local replacement for determining that we can use the dom (or essentially that we are in a browser).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates a dependency on an older version of
dom-helpers(3.2.1) which conflicts with that required byreact-transition-group(dom-helpers5.0.1). This addresses an issue using evergreen with shadow-cljs which disallows multiple versions of the same package #858 (I realise it's closed currently, there's a little more detail in my comment here).I ran tests with
avasuccessfully but did trip over some issues withxobut I believe they're not introduced by my changes.There are no ui changes with this and the portal appears to work perfectly well with the updated changes.
I wasn't sure if I should update
examples/ssr-nextor not, I had a bit more difficulty running that with something like an incompatible node version. I can dig further into this if it's helpful and update the yarn.lock there too!Thanks!