add json template function to allow escaping of environment variables #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abraithwaite
reviewed
Dec 7, 2017
| @@ -338,6 +338,30 @@ points: | |||
| } | |||
| } | |||
|
|
|||
| func TestTemplateFunc(t *testing.T) { | |||
| const configFile = "/tmp/conf-json-test.yml" | |||
There was a problem hiding this comment.
Don't need to change this, but neat func to make it more portable:
|
This is neat! 👍 Very clean way to handle these cases universally. Should we add a |
|
I’m gonna take care of the null issue in a different PR. |
abraithwaite
approved these changes
Dec 8, 2017
achille-roussel
deleted the
allow-special-characters-in-template-variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
The idea here is to allow escaping of environment variables into JSON values (which are compatible with YAML).
Please take a look and let me know if something should be changed.