-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dropdown bug in guide #573
base: main
Are you sure you want to change the base?
Conversation
my sanity is draining |
divine interventions are hindering querySelector from working properly |
…//github.com/seekr-osint/seekr into 571-website-bug-fix-dropdown-in-guide-window
…o use The CSS still has to be changed but the javascript is about done
A in dropdown value change listener is still missing but that's not that hard to add |
|
@Niteletsplay |
Cant you just use an attribute like title="test1"? |
I'll change it to do so. Everything you put as HTML will be ignored anyway. |
@Niteletsplay you can now simply add an event listener called change. const d = getDropdown("test1")
d!.addEventListener("change", function() {
console.log(getValue("test1"));
}); |
@Niteletsplay should change also be executed on selecting the item already selected and therefore not change of the value? |
No, but there shouldnt be a problem if it is |
@Niteletsplay now it only has to be implemented in guide |
Do we use this implementation in the edit view too? |
Dropdowns in edit need to be changed to the new implementation then everything is done |
@Niteletsplay don't close this pr |
1 similar comment
@Niteletsplay don't close this pr |
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Type of change
How Has This Been Tested?
Please check all browsers you have tested on. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: