Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Frame Filtering UX #352

Merged
merged 11 commits into from
May 24, 2024
Merged

Improve Frame Filtering UX #352

merged 11 commits into from
May 24, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented May 17, 2024

resolves #256

  1. Allow users to select all checkboxes in a section.
  2. Rename "Show all" button to "Clear", relating it to the checkboxes rather than the displayed frames.
  3. Add cypress test for "Clear" button.

Clarifying the behaviour of saved user preferences:

  1. When all checkboxes in a frame section are selected, this will save those themes/widths as the user's explicit preference. Future introduced themes/widths will not automatically be selected while this preference is saved.
  2. Selecting the "Clear" button will:
    • Unselect the checkboxes in the section, which will display all matching frames,
    • Clear the user preference for this section, and
    • On reload or creating a fresh playroom tab, the default options will be selected (if defaults are configured).

Allowing all checkboxes to be selected avoids some awkward interactions.

Example - I want to show all widths except 768

Before

before.mov

After

after.mov

- Allow users to select all checkboxes
- Change "Show all" prompt to "Clear filters" to emphasise the filtering pattern
- Allow users to select all checkboxes
- Change "Show all" prompt to "Clear filters" to emphasise the filtering pattern
@felixhabib felixhabib requested a review from a team as a code owner May 17, 2024 00:54
Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 6a56bc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
playroom Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@askoufis askoufis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves #256

This won't auto-close that issue. Has to be one of these keywords.

.changeset/itchy-bugs-brush.md Outdated Show resolved Hide resolved
src/Playroom/FramesPanel/FramesPanel.tsx Outdated Show resolved Hide resolved
@felixhabib felixhabib marked this pull request as draft May 22, 2024 04:27
@felixhabib felixhabib marked this pull request as ready for review May 24, 2024 01:52
@felixhabib felixhabib merged commit 7df36e3 into master May 24, 2024
7 checks passed
@felixhabib felixhabib deleted the improve-frame-filtering-ux branch May 24, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox logic could be improved
3 participants