Show max 20 canvases #158
Merged
Show max 20 canvases #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is awesome @mkamonMdt !!! testing now |
|
fixed linter on main, I would just remove the footer placeholder and call it a day |
mkamonMdt
force-pushed
the
show-max-20-canvases
branch
from
34fdbc8
to
d33ba2f
Compare
Thanks for fixing it. |
The commit introduces struct component PeerList which is to resposible for active Peer management. At current stage, the PeerList should expand and collapse, claiming dedicated screen chunk, accept (hardcoded at the moment) list of Peers and enable basic filterming function.
mkamonMdt
force-pushed
the
show-max-20-canvases
branch
from
80ce1df
to
2162974
Compare
In preparation to limit Canvases, the commit extracts a function responsible for thier preparation given vector of peer indetifiers. No changes in canvas preparation logic were introduced.
The canvas number is limited up to 20. The limit criteria is simple alphabetical order. All peers can be seen in the PeerList.
mkamonMdt
force-pushed
the
show-max-20-canvases
branch
from
2162974
to
4c3b2c2
Compare
The commit turns raw-text PeerList into scrollable list of PeerListItems, a struct component that might be further developed with functional features.
The commit adds peer heartbeat monitoring functionality that registers each heartbeat received and removes peers that stopped missed all heartbeat opportunities in current monitoring period. The heartbeat-based peer removal will take up to 2x of monitoring period duration to detect a lost peer.
* updating base images * update base image * cache build * fmt * make ci green again * pass linter
mkamonMdt
force-pushed
the
show-max-20-canvases
branch
from
4c3b2c2
to
67d3797
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR provides implementation for #39
The final output of above commits:
1 - On old view I added "Open Peers" tab that opens the PeerList
2 - The PeerList view
3- Filtering functionality