Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix conditional that was skipping all basic python tests #91

Closed
wants to merge 1 commit into from

Conversation

tyhicks
Copy link
Contributor

@tyhicks tyhicks commented Aug 24, 2017

A conditional added in ec6f45a was incorrectly comparing the (empty)
stdout of grep -q against 0, which always evaluated to be true and
skipped the basic python tests.

Fix it by using bash's pattern matching.

Signed-off-by: Tyler Hicks [email protected]

A conditional added in ec6f45a was incorrectly comparing the (empty)
stdout of grep -q against 0, which always evaluated to be true and
skipped the basic python tests.

Fix it by using bash's pattern matching.

Signed-off-by: Tyler Hicks <[email protected]>
@tyhicks
Copy link
Contributor Author

tyhicks commented Aug 24, 2017

As mentioned in #90, the CI tests fail here due to a timeout:

The job exceeded the maximum time limit for jobs, and has been terminated.

When running the tests locally without and then with this change, I see that the four basic python tests are ran and succeed. Those tests are 11-basic-basic_errors.py, 13-basic-attrs.py, 15-basic-resolver.py, and 31-basic-version_check.py.

@pcmoore
Copy link
Member

pcmoore commented Sep 12, 2017

This seems to work for everything except for test 38-basic-pfc_coverage, which is still skipped:

./regression -b 38-basic-pfc_coverage
=============== Tue Sep 12 18:37:27 EDT 2017 ===============
Regression Test Report ("regression -b 38-basic-pfc_coverage")
 batch name: 38-basic-pfc_coverage
 test mode:  c
 test type:  basic
Test 38-basic-pfc_coverage%%001-00001 result:   SUCCESS
 batch name: 38-basic-pfc_coverage
 test mode:  python
 test type:  basic
Test 38-basic-pfc_coverage%%001-00001 result:   SKIPPED (only valid in native/c mode)
Regression Test Summary
 tests run: 1
 tests skipped: 1
 tests passed: 1
 tests failed: 0
 tests errored: 0
============================================================

I haven't done much debugging on this yet, but wanted to mention it in case you ran across something like this after the PR was posted.

@pcmoore
Copy link
Member

pcmoore commented Sep 12, 2017

Ah, wait, nevermind, my mistake ... this looks fine, I was just a bit rusty and looking at this wrong, sorry for the confusion.

@pcmoore
Copy link
Member

pcmoore commented Sep 12, 2017

Merged via b503129

@pcmoore pcmoore closed this Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants