RFE: utility for resolving architectures #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for reusing the code that translates an architecture token into a human readable string. Signed-off-by: Tyler Hicks <[email protected]>
Add a utility, scmp_arch_resolver, to translate architecture tokens to human readable strings and back. This may be useful, for example, when needing to understand the "arch=N" portion of seccomp audit messages. The Makefile.am is configured so that scmp_arch_resolver is not installed at this time but that's something that can always be changed if the utility proves to be useful. Signed-off-by: Tyler Hicks <[email protected]>
|
Without looking at the code too closely, one thing jumps out at me: the libseccomp arch token is not the same as the "arch" field reported by the kernel's audit records, see x86_64/x32 as an example. |
|
Okay, I'm going to close this out without merging because of the reasons listed above. If you really want to translate the architecture token in the audit messages, I might suggest using the ausearch tool with the '-i' parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an (uninstalled) utility for resolving architecture tokens into names suitable for reading.