RFE: refined header comment for seccomp_arch_add
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoore
changed the title
seccomp_arch_add.seccomp_arch_add
|
Hello and thank you for the PR. Could you please read the SUBMITTING_PATCHES file, especially the "Sign Your Work" section and update the commit message with your sign-off? |
Refined `seccomp_arch_add` to be more verbose about return code `-EEXIST` in case of existing arch in filter. Adding this information helps developers write code to safely ignore the ret code in this case. Signed-off-by: Jiannan Guo <[email protected]>
|
@pcmoore commit message updated! cheers. |
|
Looks good to me - thanks! |
|
Merged via 5bcf70b. |
pcmoore
added a commit
to pcmoore/misc-libseccomp
that referenced
this pull request
Nov 5, 2019
Signed-off-by: Paul Moore <[email protected]>
pcmoore
added a commit
to pcmoore/misc-libseccomp
that referenced
this pull request
Nov 6, 2019
Signed-off-by: Paul Moore <[email protected]>
pcmoore
added a commit
that referenced
this pull request
Nov 14, 2019
Signed-off-by: Paul Moore <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error code
-EEXISTis returned by this interface if specified archis already present. Added this information to header comment since it helps
developers to write code that safely ignores this ret code.