BUG: avoid use of non-portable which in the tests
#424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is not a standard POSIX utility, and indeed, each of these test scripts uses #!/bin/bash as its shebang, so we can use `type -P` which has the same behaviour as `which` for free. (If the tests used POSIX shell, we could do `command -v`, its only caveat is that it'll pick up functions in the user's shell, which doesn't matter 99% of the time anyway.) Distributions like Debian [0] and Gentoo [1] are looking to remove `which` from their base set of packages. [0] https://lwn.net/Articles/874049/ [1] https://bugs.gentoo.org/646588 Signed-off-by: Sam James <[email protected]>
pcmoore
changed the title
whichwhich in the tests
|
Hi @thesamesam, first off, great branch name :) Other than that, this patch looks good to me, and considering the trivial nature I'm going to go ahead and merge this into main via 47ca644. @drakenclimber if you have any concerns/objections please let me know and we can fix things up, or revert this patch if needed. Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which is not a standard POSIX utility, and indeed, each of these test scripts uses #!/bin/bash as its shebang, so we can use
type -Pwhich has the same behaviour aswhichfor free.(If the tests used POSIX shell, we could do
command -v, its only caveat is that it'll pick up functions in the user's shell, which doesn't matter 99% of the time anyway.)Distributions like Debian [0] and Gentoo [1] are looking to remove
whichfrom their base set of packages.[0] https://lwn.net/Articles/874049/
[1] https://bugs.gentoo.org/646588