Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: sort out simulation blacklist/whitelist #38

Closed
wants to merge 1 commit into from

Conversation

lucab
Copy link
Contributor

@lucab lucab commented May 29, 2016

This commit sorts out a mismatch between simulation tests,
properly laying down a blacklist and a whitelist simulation.
Fixes #35

Signed-off-by: Luca Bruno [email protected]

@pcmoore pcmoore added the bug label May 31, 2016
@pcmoore pcmoore added this to the v2.4 milestone May 31, 2016
@pcmoore
Copy link
Member

pcmoore commented May 31, 2016

Thanks for the PR! If it isn't too much trouble could you please add test 34 to tests/.gitignore?

This commit sorts out a mismatch between simulation tests,
properly laying down a blacklist and a whitelist simulation.

Signed-off-by: Luca Bruno <[email protected]>
@lucab lucab force-pushed the to-upstream/blacklist-test branch from a27b543 to 0224e62 Compare May 31, 2016 19:08
@lucab
Copy link
Contributor Author

lucab commented May 31, 2016

Ah, I didn't spot the nested .gitignore before. Amended.

@pcmoore
Copy link
Member

pcmoore commented Jun 2, 2016

Merged in 5e0a33f, thanks!

@pcmoore pcmoore closed this Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants