BUG: use python 3.8 to prevent cython install failure #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Waldon <[email protected]>
|
Awesome!!! Thank you so much! I didn't realize how tightly coupled Cython and our libseccomp code is with newer versions of Python. I figured v3.6 would be new enough and blindly continued down that path.
|
|
It seems like it would be valuable to understand why we need to use really recent versions of Python, but that doesn't seem like a reason not to deploy this fix now. |
pcmoore
changed the title
|
Hi @whereswaldon, thanks for the help and the patch! Let's continue the broader discussion on how to resolve this over in #199. |
|
Let's close this out in favor of #202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to make the existing tests work by just switching back to the latest stable release of Python. I don't pretend to understand the problems that you were trying to debug @drakenclimber, but perhaps this will work reliably? I had a successful build on it here.
Signed-off-by: Chris Waldon [email protected]