Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: golang: add missing architectures #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RFE: golang: add missing architectures #106

wants to merge 1 commit into from
+61 −1

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Mar 9, 2023 •
edited

Add a few more missing architectures:

  • LOONG64
  • M68K
  • SH and SHEB

@kolyshkin kolyshkin mentioned this pull request Mar 9, 2023
Draft
@kolyshkin kolyshkin mentioned this pull request Mar 10, 2023
Closed
@zhaixiaojuan zhaixiaojuan mentioned this pull request Mar 15, 2023
Open
@zhaixiaojuan
Copy link

@kolyshkin
Hi kolyshkin，
I'm very sorry, maybe my understanding is wrong, it is mentioned in this PR that ArchLOONGARCH64 should be used. In the libseccomp-go project, how do you understand this problem.

@kolyshkin
Copy link
Contributor Author

@kolyshkin Hi kolyshkin， I'm very sorry, maybe my understanding is wrong, it is mentioned in this PR that ArchLOONGARCH64 should be used. In the libseccomp-go project, how do you understand this problem.

Reworked to put the "ARCH" suffix back. It is now LOONGARCH64 everywhere.

@AkihiroSuda
Copy link

What's current status?

@AkihiroSuda AkihiroSuda mentioned this pull request Sep 26, 2023
Open
@zhaixiaojuan
Copy link

@kolyshkin
Hi kolyshkin, Could you consider merging this PR?

@znley
Copy link

znley commented May 8, 2024

What's current status?

@kolyshkin
Copy link
Contributor Author

@drakenclimber @pcmoore PTAL

@pcmoore
Copy link
Member

pcmoore commented May 9, 2024

Looks good to me.

Acked-by: Paul Moore <[email protected]>

@kolyshkin kolyshkin changed the title RFE: golang: add LOONG64 support RFE: golang: add missing architectures May 10, 2024
drakenclimber
drakenclimber approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@drakenclimber drakenclimber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @kolyshkin

Acked-by: Tom Hromatka <[email protected]>

timscharfenort8
timscharfenort8 approved these changes May 26, 2024
View reviewed changes
Copy link

@timscharfenort8 timscharfenort8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda left review comments

@drakenclimber drakenclimber drakenclimber approved these changes

@pcmoore pcmoore pcmoore approved these changes

@timscharfenort8 timscharfenort8 timscharfenort8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kolyshkin @zhaixiaojuan @AkihiroSuda @znley @pcmoore @drakenclimber @timscharfenort8