This repository has been archived by the owner on Apr 12, 2022. It is now read-only.
refactor logging for finishWithError #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactor also fix the following problems: 1. log level was missing when logging failure that reaches max_attemps(line 280 before) 2. add error message in logging to get a better idea why it failed( line 290 wasn't logging error before). thanks.
sorry about that.. new to github pull request :)
|
Seems legit. |
josegonzalez
added a commit
that referenced
this pull request
Aug 29, 2013
refactor logging for finishWithError
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactor also fix the following problems:
thanks.